Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: [okx] generate ticker request by requestgen #1492

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

bailantaotao
Copy link
Collaborator

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 778 BBG.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (2beec1d) 21.52% compared to head (188b781) 21.56%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1492      +/-   ##
==========================================
+ Coverage   21.52%   21.56%   +0.03%     
==========================================
  Files         599      601       +2     
  Lines       44121    44091      -30     
==========================================
+ Hits         9499     9508       +9     
+ Misses      33929    33890      -39     
  Partials      693      693              
Files Coverage Δ
pkg/exchange/okex/okexapi/client.go 9.62% <ø> (+2.48%) ⬆️
pkg/exchange/okex/okexapi/get_ticker_request.go 100.00% <100.00%> (ø)
pkg/exchange/okex/okexapi/get_tickers_request.go 100.00% <100.00%> (ø)
pkg/exchange/okex/exchange.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2beec1d...188b781. Read the comment docs.

@bailantaotao bailantaotao merged commit c2e3fed into main Jan 9, 2024
4 checks passed
@bailantaotao bailantaotao deleted the edwin/okx/refactor-tickers branch January 9, 2024 07:38
@bbgokarma-bot
Copy link

Hi @bailantaotao,

Well done! 788 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x85f06af58d7a1f37ef87ed85e57427b7ea6d6e70972de8bd8d65d39227a757a4

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants